Skip to content

Minor update -> testing with redisvl#1

Merged
rbs333 merged 3 commits into
mainfrom
feat/redisvl-integration-tests
Jan 27, 2026
Merged

Minor update -> testing with redisvl#1
rbs333 merged 3 commits into
mainfrom
feat/redisvl-integration-tests

Conversation

@rbs333

@rbs333 rbs333 commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

I'm experimenting with adding this package as an optional dep to redisvl.

Meaning pip install redisvl[sql] would allow for the SQLQuery class which would utilize this package under the hood. After thinking about it for a bit, I think this would be the correct way to package since redisvl should not own code for SQL->Redis type queries. However, since it's within redisvl purview to make it easier to interact with complex query interaction I believe the class there will make a lot of sense (and be popular).

To this goal, I've added linting and other stuff to this repo so it gets a bit more polish if we do move towards a more generalized release.

@rbs333 rbs333 requested a review from abrookins January 27, 2026 18:32

@abrookins abrookins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

strategy:
matrix:
python-version:
- "3.9"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might keep 3.10 and remove 3.9 here. Due to end-of-life timelines and such.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heard. I relaxed because it was causing a dep graph issue since redisvl allows for lower version now

strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, would remove 3.9.

@rbs333 rbs333 merged commit f002ce9 into main Jan 27, 2026
8 checks passed
@rbs333 rbs333 deleted the feat/redisvl-integration-tests branch January 27, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants